Skip to content

fix: commit pending proposals recovery strategy - WPB-23159 #4254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
netbe wants to merge 11 commits into
base: release/cycle-4.15
Choose a base branch
from
Open

fix: commit pending proposals recovery strategy - WPB-23159 #4254

netbe wants to merge 11 commits into from

Conversation

@netbe
Copy link
Collaborator

@netbe netbe commented Feb 3, 2026 •
edited by github-actions bot
Loading

TaskWPB-23159 [iOS] Change Commit Pending Proposals recovery

Issue

  • clear commit pending proposal date when mls reset
  • change recovery strategy to a backoff retry instead of retryaftersync
  • avoid sending commit to non existing groups
  • clear scheduled items from workAgent queue when sync is suspended. These will be recreated if needed.
  • cleanup setup initiate mls reset use case
  • improve debugging workAgent item (changed ids)

Testing

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026 •
edited
Loading

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 004b32c.

♻️ This comment has been updated with latest results.

Summary: workflow run #21755087570
Allure report (download zip): html-report-27651-fix_commit-pending-proposals-WPB-23159

@netbe netbe requested review from johnxnguyen and samwyndham and removed request for johnxnguyen February 3, 2026 13:37
@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 3, 2026 •
edited
Loading

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 82adc38 | Docs | Was this helpful? Give us feedback!

johnxnguyen
johnxnguyen reviewed Feb 4, 2026
View reviewed changes
samwyndham
samwyndham reviewed Feb 4, 2026
View reviewed changes
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@netbe Remember to re-target this to 4.15 release branch

@netbe netbe changed the base branch from release/cycle-4.14 to release/cycle-4.15 February 4, 2026 14:11
@netbe netbe force-pushed the fix/commit-pending-proposals-WPB-23159 branch from 82adc38 to 0369bbd Compare February 4, 2026 14:43
samwyndham
samwyndham reviewed Feb 5, 2026
View reviewed changes
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've added just a couple of comments before approval

@netbe netbe requested a review from samwyndham February 5, 2026 09:46
samwyndham
samwyndham approved these changes Feb 5, 2026
View reviewed changes
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@netbe netbe enabled auto-merge (squash) February 6, 2026 15:04
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2026

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samwyndham samwyndham samwyndham approved these changes

@johnxnguyen johnxnguyen johnxnguyen approved these changes

Assignees

@netbe netbe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@netbe @samwyndham @johnxnguyen